Skip to content

Use graphql infrastructure to parse requests #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

Andy2003
Copy link
Collaborator

Using the graphql infrastructure for parsing the request ensures that:

  • the request is compliant with the schema
  • internally we can rely on DataFetchingEnvironment being correctly initialized

Using the graphql infrastructure for parsing the request ensures that:
* the request is compliant with the schema
* internally we can rely on `DataFetchingEnvironment` being correctly initialized
@Andy2003 Andy2003 added the enhancement New feature or request label Nov 16, 2021
@Andy2003 Andy2003 requested a review from jexp November 16, 2021 10:25
@github-actions
Copy link

Unit Test Results

    5 files  ±0      5 suites  ±0   1m 0s ⏱️ +3s
186 tests ±0  182 ✔️ ±0  4 💤 ±0  0 ±0 
718 runs  ±0  712 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit e34613c. ± Comparison against base commit 0f81665.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
sort.adoc ‑ tck-test-files/cypher/sort.adoc:[Cypher pagination tests][For projection][Sort with skip limit & with other variables][Test Cypher Params]
sort.adoc ‑ tck-test-files/cypher/sort.adoc:[Cypher pagination tests][For projection][Sort with skip limit & with other variables][Test Cypher]
sort.adoc ‑ tck-test-files/cypher/sort.adoc:[Cypher pagination tests][For query][Sort with skip limit & with other variables][Test Cypher Params]
sort.adoc ‑ tck-test-files/cypher/sort.adoc:[Cypher pagination tests][For query][Sort with skip limit & with other variables][Test Cypher]
sort.adoc ‑ tck-test-files/cypher/sort.adoc:[Cypher pagination tests][For projection][Sort with skip limit & with other variables][Test Cypher Params]
sort.adoc ‑ tck-test-files/cypher/sort.adoc:[Cypher pagination tests][For projection][Sort with skip limit & with other variables][Test Cypher]
sort.adoc ‑ tck-test-files/cypher/sort.adoc:[Cypher pagination tests][For query][Sort with skip limit & with other variables][Test Cypher Params]
sort.adoc ‑ tck-test-files/cypher/sort.adoc:[Cypher pagination tests][For query][Sort with skip limit & with other variables][Test Cypher]

@Andy2003 Andy2003 merged commit a388606 into master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant