Skip to content

GDS 2.x update and trimming #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2022
Merged

GDS 2.x update and trimming #17

merged 1 commit into from
Apr 13, 2022

Conversation

cj2001
Copy link

@cj2001 cj2001 commented Apr 12, 2022

This PR updates the fraud detection browser guide to be compliant with GDS 2.x. In addition, Field has pointed out that the original guide was too much and more of a tutorial with exercises than a browser guide. As such, @pdathar created this new, trimmed down browser guide using the PaySim dataset.

I have created this PR and, since there are many changes, figured that there should be review of it by multiple stakeholders. However, this is Phani's work so I leave it to him to address the changes.

If there are stakeholders who are not already listed on this PR, please feel free to add them!

/cc @pdathar for addressing feedback and moving this PR forward
/cc @zach-blumenfeld @jexp @voutilad for review
/cc @AliciaFrame @moxious for visibiliy, comment, and/or review

@cj2001 cj2001 added the documentation Improvements or additions to documentation label Apr 12, 2022
@cj2001 cj2001 requested a review from jexp April 12, 2022 16:33
Copy link
Contributor

@jexp jexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot.
Shall I push it to s3?

@jexp jexp merged commit 4e45e1e into main Apr 13, 2022
@pdathar
Copy link

pdathar commented Apr 13, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants