Bringing over .net Testkit changes. (#115)

* Enabling tests that use VerifyConnectivity and MultiDBSupport

* Enabled test in .Net

 test_should_request_rt_from_all_initial_routers_until_successful

* Enabling tests that use ROUTE message now that bookmark is implemented

* Enabled dotnet in tests:

test_should_successfully_get_server_agent
test_should_successfully_get_server_protocol_version

* Enabling two tests for dotnet

test_should_successfully_get_server_protocol_version
test_should_successfully_get_server_agent

* Enabled GetFeatures and authorization tests

Author: AndyHeap-NeoTech

tests/shared.py

@@ -69,11 +69,6 @@ def __call__(self, *args, **kwargs):
 
 @MemoizedSupplier
 def get_driver_features(backend):
-    # TODO Remove when dotnet implements the GetFeature message
-    if get_driver_name() in ['dotnet', 'java']:
-        warnings.warn("Driver does not implements GetFeatures.")
-        features = ()
-        return features
 
     try:
         response = backend.sendAndReceive(protocol.GetFeatures())

tests/stub/authorization.py

@@ -35,6 +35,8 @@ def assert_is_authorization_error(self, error):
         elif driver in ['javascript']:
             # only test for code
             pass
+        elif driver in ['dotnet']:
+            self.assertEqual("AuthorizationExpired", error.errorType)
         else:
             self.fail("no error mapping is defined for %s driver" % driver)
 
@@ -223,7 +225,7 @@ def switch_unused_servers(self, servers, new_script):
     def test_should_fail_with_auth_expired_on_pull_using_session_run(
             self):
         # TODO remove this block once all languages work
-        if get_driver_name() in ['go', 'dotnet']:
+        if get_driver_name() in ['go']:
             self.skipTest("requires authorization expired response support")
         driver = Driver(self._backend, self._uri, self._auth,
                         userAgent=self._userAgent)
@@ -236,7 +238,7 @@ def test_should_fail_with_auth_expired_on_pull_using_session_run(
 
         session = driver.session('r', database=self.get_db())
         try:
-            session.run("RETURN 1 as n").consume()
+            session.run("RETURN 1 as n")
         except types.DriverError as e:
             self.assert_is_authorization_error(error=e)
         session.close()
@@ -247,7 +249,7 @@ def test_should_fail_with_auth_expired_on_pull_using_session_run(
 
     def test_should_fail_with_auth_expired_on_begin_using_tx_run(self):
         # TODO remove this block once all languages work
-        if get_driver_name() in ['go', 'dotnet']:
+        if get_driver_name() in ['go']:
             self.skipTest("requires authorization expired response support")
         driver = Driver(self._backend, self._uri, self._auth,
                         userAgent=self._userAgent)
@@ -274,7 +276,7 @@ def test_should_fail_with_auth_expired_on_begin_using_tx_run(self):
 
     def test_should_fail_with_auth_expired_on_run_using_tx_run(self):
         # TODO remove this block once all languages work
-        if get_driver_name() in ['go', 'dotnet']:
+        if get_driver_name() in ['go']:
             self.skipTest("requires authorization expired response support")
         driver = Driver(self._backend, self._uri, self._auth,
                         userAgent=self._userAgent)
@@ -299,7 +301,7 @@ def test_should_fail_with_auth_expired_on_run_using_tx_run(self):
 
     def test_should_fail_with_auth_expired_on_pull_using_tx_run(self):
         # TODO remove this block once all languages work
-        if get_driver_name() in ['go', 'dotnet']:
+        if get_driver_name() in ['go']:
             self.skipTest("requires authorization expired response support")
         driver = Driver(self._backend, self._uri, self._auth,
                         userAgent=self._userAgent)
@@ -324,7 +326,7 @@ def test_should_fail_with_auth_expired_on_pull_using_tx_run(self):
 
     def test_should_fail_with_auth_expired_on_commit_using_tx_run(self):
         # TODO remove this block once all languages work
-        if get_driver_name() in ['go', 'dotnet']:
+        if get_driver_name() in ['go']:
             self.skipTest("requires authorization expired response support")
         driver = Driver(self._backend, self._uri, self._auth,
                         userAgent=self._userAgent)
@@ -350,7 +352,7 @@ def test_should_fail_with_auth_expired_on_commit_using_tx_run(self):
 
     def test_should_fail_with_auth_expired_on_rollback_using_tx_run(self):
         # TODO remove this block once all languages work
-        if get_driver_name() in ['go', 'dotnet']:
+        if get_driver_name() in ['go']:
             self.skipTest("requires authorization expired response support")
         driver = Driver(self._backend, self._uri, self._auth,
                         userAgent=self._userAgent)
@@ -377,7 +379,7 @@ def test_should_fail_with_auth_expired_on_rollback_using_tx_run(self):
     def test_should_retry_on_auth_expired_on_begin_using_tx_function(
             self):
         # TODO remove this block once all languages work
-        if get_driver_name() in ['go','dotnet']:
+        if get_driver_name() in ['go']:
             self.skipTest("requires authorization expired response support")
         driver = Driver(self._backend, self._uri, self._auth,
                         userAgent=self._userAgent)
@@ -419,7 +421,7 @@ def work(tx):
     def test_should_retry_on_auth_expired_on_run_using_tx_function(
             self):
         # TODO remove this block once all languages work
-        if get_driver_name() in ['go', 'dotnet']:
+        if get_driver_name() in ['go']:
             self.skipTest("requires authorization expired response support")
         driver = Driver(self._backend, self._uri, self._auth,
                         userAgent=self._userAgent)
@@ -461,7 +463,7 @@ def work(tx):
     def test_should_retry_on_auth_expired_on_pull_using_tx_function(
             self):
         # TODO remove this block once all languages work
-        if get_driver_name() in ['go', 'dotnet']:
+        if get_driver_name() in ['go']:
             self.skipTest("requires authorization expired response support")
         driver = Driver(self._backend, self._uri, self._auth,
                         userAgent=self._userAgent)
@@ -503,7 +505,7 @@ def work(tx):
     def test_should_retry_on_auth_expired_on_commit_using_tx_function(
             self):
         # TODO remove this block once all languages work
-        if get_driver_name() in ['go', 'dotnet']:
+        if get_driver_name() in ['go']:
             self.skipTest("requires authorization expired response support")
         driver = Driver(self._backend, self._uri, self._auth,
                         userAgent=self._userAgent)

tests/stub/routing/test_routing_v4x3.py

@@ -660,7 +660,6 @@ def test_should_use_read_session_mode_and_initial_bookmark_when_reading_using_tx
         self.assertEqual(["NewBookmark"], last_bookmarks)
 
     def test_should_pass_bookmark_from_tx_to_tx_using_tx_run(self):
-        # TODO remove this block once all languages work
         driver = Driver(self._backend, self._uri_with_context, self._auth,
                         self._userAgent)
         self.start_server(self._routingServer1, "router_adb.script")
@@ -1543,9 +1542,6 @@ def test_should_pass_system_bookmark_when_getting_rt_for_multi_db(self):
         pass
 
     def test_should_ignore_system_bookmark_when_getting_rt_for_multi_db(self):
-        # TODO remove this block once all languages work
-        if get_driver_name() in ['dotnet']:
-            self.skipTest("needs ROUTE bookmark list support")
         driver = Driver(self._backend, self._uri_with_context, self._auth,
                         self._userAgent)
         self.start_server(self._routingServer1, "router_adb.script")
@@ -1642,9 +1638,8 @@ def domainNameResolver(name):
 
     def test_should_successfully_acquire_rt_when_router_ip_changes(self):
         # TODO remove this block once all languages work
-        if get_driver_name() in ['dotnet']:
-            self.skipTest("needs ROUTE bookmark list support")
-        if get_driver_name() in ['dotnet', 'go']:
+
+        if get_driver_name() in ['go']:
             self.skipTest("needs verifyConnectivity support")
         ip_addresses = []
         if platform == "linux":