Skip to content

Commit 13a7227

Browse files
authored
minor better nav heighting (#319)
1 parent e41d8ea commit 13a7227

File tree

5 files changed

+22
-24
lines changed

5 files changed

+22
-24
lines changed

preview-src/admonitions.adoc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
= Admonitions
22
:check-mark: icon:check[]
3+
// :page-disablefeedback: true
34

45

56
== NOTE
@@ -27,7 +28,7 @@ Eos suscipit scaevola at.
2728

2829
Cum dicat putant ne.
2930
Est in reque homero principes, meis deleniti mediocrem ad has.
30-
Altera atomorum his ex, has cu elitr melius propriae.
31+
// Altera atomorum his ex, has cu elitr melius propriae.
3132

3233
[TIP]
3334
====

preview-src/ui-model.yml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,21 @@ page:
265265
- content: GraphGists
266266
url: graph-gist-index.html
267267
urlType: internal
268+
- content: Star Wars Social Network
269+
url: graph-gist-star-wars-social-network.html
270+
urlType: internal
271+
- content: First Steps with Cypher
272+
url: first-steps-with-cypher.html
273+
urlType: internal
274+
- content: Category Pop Culture
275+
url: graph-gist-category-pop-culture.html
276+
urlType: internal
277+
- content: Contribute
278+
url: contribute.html
279+
urlType: internal
280+
- content: Promos
281+
url: promos.html
282+
urlType: internal
268283
- content: Reference - a long title that also has child pages
269284
items:
270285
- content: Keyboard Shortcuts
@@ -283,21 +298,6 @@ page:
283298
- content: English + 中文
284299
url: '/xyz/4.1/index.html#english+中文'
285300
urlType: internal
286-
- content: Star Wars Social Network
287-
url: graph-gist-star-wars-social-network.html
288-
urlType: internal
289-
- content: First Steps with Cypher
290-
url: first-steps-with-cypher.html
291-
urlType: internal
292-
- content: Category Pop Culture
293-
url: graph-gist-category-pop-culture.html
294-
urlType: internal
295-
- content: Contribute
296-
url: contribute.html
297-
urlType: internal
298-
- content: Promos
299-
url: promos.html
300-
urlType: internal
301301
# additional page attributes indexed by page-slug
302302
pages-data:
303303
cheatsheet-products: &cheatsheet-products

src/css/nav.css

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,9 @@ html.is-clipped--nav {
157157
position: relative;
158158
}
159159

160-
.nav-panel-manu.has-feedback .nav-menu {
161-
margin-bottom: calc(var(--feedback-height) + 1rem);
160+
.nav-panel-menu.has-feedback {
161+
height: calc(var(--nav-panel-height--desktop) - var(--feedback-height) - 1.5rem);
162+
padding-bottom: calc(var(--feedback-height) * 1.5);
162163
}
163164

164165
.nav-menu .component-title {

src/css/vars.css

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -406,11 +406,7 @@
406406
--nav-height: calc(var(--body-min-height) - var(--toolbar-height));
407407
--nav-height--desktop: var(--body-min-height);
408408
--nav-panel-height: calc(var(--nav-height) - var(--drawer-height));
409-
--nav-panel-height--desktop:
410-
calc(
411-
var(--nav-height--desktop) - var(--drawer-height) - var(--feedback-height) * 8px
412-
); /* 1rem is feedback padding */
413-
409+
--nav-panel-height--desktop: calc(var(--nav-height--desktop) - var(--drawer-height));
414410
--nav-width: 18rem;
415411
--toc-top: calc(var(--body-top) + var(--toolbar-height));
416412
--kb-metadata-top: calc(var(--body-top) + var(--toolbar-height));

src/partials/nav-menu.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
</div>
77
</aside>
88
{{else}}
9-
<div class="nav-panel-menu is-active" data-panel="menu">
9+
<div class="nav-panel-menu is-active{{#unless page.attributes.disablefeedback}} has-feedback{{/unless}}" data-panel="menu">
1010
<nav class="nav-menu">
1111
{{#with page.navigation}}{{> nav-tree navigation=this module=@root.page.module}}{{/with}}
1212
</nav>

0 commit comments

Comments
 (0)