Amend NEP-2 #17
Merged
Amend NEP-2 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decryption results in a plaintext key, not encrypted key
Make text more consistent by using the actual name provided in step 1. The name ‘salt’ is only relevant for the scrypt function, not for the actual final key data structure. It also more closely matches the actual implementation @ https://github.com/neo-project/neo/blob/master/neo/Wallets/KeyPair.cs#L7 5
erikzhang
approved these changes
Nov 2, 2017
lerider
added a commit
to lerider/proposals
that referenced
this pull request
Nov 2, 2017
Amend NEP-2 (neo-project#17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for detailed reasoning