Skip to content

Commit 0a99ef6

Browse files
committed
BREAKING! Eliminate separate reset_all_parameters_clause & _stmt
Instead there's now all_parameters node to represent the ALL keyword.
1 parent 9a37a82 commit 0a99ef6

File tree

5 files changed

+15
-56
lines changed

5 files changed

+15
-56
lines changed

src/cst/Function.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import { SubSelect } from "./Select";
1414
import { BlockStmt } from "./ProceduralLanguage";
1515
import { AlterFunctionAction } from "./AlterAction";
1616
import {
17-
ResetAllParametersClause,
1817
ResetParameterClause,
1918
SetParameterClause,
2019
SetParameterFromCurrentClause,
@@ -211,7 +210,6 @@ type AlterFunctionClause =
211210
| SetParameterClause
212211
| SetParameterFromCurrentClause
213212
| ResetParameterClause
214-
| ResetAllParametersClause
215213
| FunctionBehaviorClause
216214
| FunctionSecurityClause
217215
| FunctionCostClause

src/cst/Parameter.ts

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,13 @@ export type AllParameterNodes =
88
| SetParameterClause
99
| SetParameterFromCurrentClause
1010
| ResetParameterClause
11-
| ResetAllParametersClause;
11+
| AllParameters;
1212

1313
export type AllParameterStatements =
1414
| SetParameterStmt
1515
| SetTimeZoneParameterStmt
1616
| ResetParameterStmt
17-
| ResetAllParametersStmt
18-
| ShowParameterStmt
19-
| ShowAllParametersStmt;
17+
| ShowParameterStmt;
2018

2119
// These are all PostgreSQL specific
2220
export interface SetParameterStmt extends BaseNode {
@@ -39,23 +37,13 @@ export interface SetTimeZoneParameterStmt extends BaseNode {
3937
export interface ResetParameterStmt extends BaseNode {
4038
type: "reset_parameter_stmt";
4139
resetKw: Keyword<"RESET">;
42-
name: Identifier;
43-
}
44-
45-
export interface ResetAllParametersStmt extends BaseNode {
46-
type: "reset_all_parameters_stmt";
47-
resetAllKw: [Keyword<"RESET">, Keyword<"ALL">];
40+
name: Identifier | AllParameters;
4841
}
4942

5043
export interface ShowParameterStmt extends BaseNode {
5144
type: "show_parameter_stmt";
5245
showKw: Keyword<"SHOW">;
53-
name: Identifier;
54-
}
55-
56-
export interface ShowAllParametersStmt extends BaseNode {
57-
type: "show_all_parameters_stmt";
58-
showAllKw: [Keyword<"SHOW">, Keyword<"ALL">];
46+
name: Identifier | AllParameters;
5947
}
6048

6149
export interface SetParameterClause extends BaseNode {
@@ -76,10 +64,10 @@ export interface SetParameterFromCurrentClause extends BaseNode {
7664
export interface ResetParameterClause extends BaseNode {
7765
type: "reset_parameter_clause";
7866
resetKw: Keyword<"RESET">;
79-
name: Identifier;
67+
name: Identifier | AllParameters;
8068
}
8169

82-
export interface ResetAllParametersClause extends BaseNode {
83-
type: "reset_all_parameters_clause";
84-
resetAllKw: [Keyword<"RESET">, Keyword<"ALL">];
70+
export interface AllParameters extends BaseNode {
71+
type: "all_parameters";
72+
allKw: Keyword<"ALL">;
8573
}

src/cst/Procedure.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
} from "./Function";
1313
import { AlterFunctionAction } from "./AlterAction";
1414
import {
15-
ResetAllParametersClause,
1615
ResetParameterClause,
1716
SetParameterClause,
1817
SetParameterFromCurrentClause,
@@ -74,5 +73,4 @@ type AlterProcedureClause =
7473
| SetParameterClause
7574
| SetParameterFromCurrentClause
7675
| ResetParameterClause
77-
| ResetAllParametersClause
7876
| FunctionSecurityClause;

src/parser.pegjs

Lines changed: 6 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,7 @@ statement_postgres
109109
/ set_parameter_stmt
110110
/ set_time_zone_parameter_stmt
111111
/ reset_parameter_stmt
112-
/ reset_all_parameters_stmt
113112
/ show_parameter_stmt
114-
/ show_all_parameters_stmt
115113

116114
ddl_statement
117115
= create_view_stmt
@@ -3983,7 +3981,6 @@ alter_function_action
39833981
/ alter_action_no_depends_on_extension
39843982
/ set_parameter_clause
39853983
/ set_parameter_from_current_clause
3986-
/ reset_all_parameters_clause
39873984
/ reset_parameter_clause
39883985
/ function_behavior_clause
39893986
/ function_security_clause
@@ -4115,7 +4112,6 @@ alter_procedure_action
41154112
/ alter_action_no_depends_on_extension
41164113
/ set_parameter_clause
41174114
/ set_parameter_from_current_clause
4118-
/ reset_all_parameters_clause
41194115
/ reset_parameter_clause
41204116
/ function_security_clause
41214117

@@ -5969,54 +5965,35 @@ set_parameter_from_current_clause
59695965
}
59705966

59715967
reset_parameter_stmt
5972-
= kw:(RESET __) name:ident {
5968+
= kw:(RESET __) name:(all_parameters / ident) {
59735969
return loc({
59745970
type: "reset_parameter_stmt",
59755971
resetKw: read(kw),
59765972
name,
59775973
});
59785974
}
59795975

5980-
reset_all_parameters_stmt
5981-
= kw:(RESET __ ALL) {
5982-
return loc({
5983-
type: "reset_all_parameters_stmt",
5984-
resetAllKw: read(kw),
5985-
});
5986-
}
5987-
59885976
reset_parameter_clause
5989-
= kw:(RESET __) name:ident {
5977+
= kw:(RESET __) name:(all_parameters / ident) {
59905978
return loc({
59915979
type: "reset_parameter_clause",
59925980
resetKw: read(kw),
59935981
name,
59945982
});
59955983
}
59965984

5997-
reset_all_parameters_clause
5998-
= kw:(RESET __ ALL) {
5999-
return loc({
6000-
type: "reset_all_parameters_clause",
6001-
resetAllKw: read(kw),
6002-
});
6003-
}
6004-
60055985
show_parameter_stmt
6006-
= kw:(SHOW __) name:ident {
5986+
= kw:(SHOW __) name:(all_parameters / ident) {
60075987
return loc({
60085988
type: "show_parameter_stmt",
60095989
showKw: read(kw),
60105990
name,
60115991
});
60125992
}
60135993

6014-
show_all_parameters_stmt
6015-
= kw:(SHOW __ ALL) {
6016-
return loc({
6017-
type: "show_all_parameters_stmt",
6018-
showAllKw: read(kw),
6019-
});
5994+
all_parameters
5995+
= allKw:ALL {
5996+
return loc({ type: "all_parameters", allKw });
60205997
}
60215998

60225999
postgresql_with_options

src/showNode/parameter.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,11 @@ export const parameterMap: FullTransformMap<string, AllParameterNodes> = {
88
set_time_zone_parameter_stmt: (node) =>
99
show([node.setKw, node.modifierKw, node.timeZoneKw, node.value]),
1010
reset_parameter_stmt: (node) => show([node.resetKw, node.name]),
11-
reset_all_parameters_stmt: (node) => show(node.resetAllKw),
1211
show_parameter_stmt: (node) => show([node.showKw, node.name]),
13-
show_all_parameters_stmt: (node) => show(node.showAllKw),
1412
set_parameter_clause: (node) =>
1513
show([node.setKw, node.name, node.operator, node.value]),
1614
set_parameter_from_current_clause: (node) =>
1715
show([node.setKw, node.name, node.fromCurrentKw]),
1816
reset_parameter_clause: (node) => show([node.resetKw, node.name]),
19-
reset_all_parameters_clause: (node) => show([node.resetAllKw]),
17+
all_parameters: (node) => show([node.allKw]),
2018
};

0 commit comments

Comments
 (0)