Skip to content

Windowsでファイルパスのパースに失敗するバグを修正 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2018
Merged

Windowsでファイルパスのパースに失敗するバグを修正 #14

merged 1 commit into from
Oct 23, 2018

Conversation

neet
Copy link
Owner

@neet neet commented Oct 23, 2018

Uri.parseはNode.jsのnew URL.constructorと挙動が異なり、ファイルパスのパースに失敗していたので、適切なメソッド Uri.fileに変更。

  • 同様のpull requestが無いか調べました。

@neet neet merged commit d235706 into master Oct 23, 2018
@neet neet deleted the patch-windows-broken-path branch October 23, 2018 11:58
@neet neet mentioned this pull request Oct 23, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@neet