Skip to content

Commit

Permalink
samples/bpf: Remove the xdp_sample_pkts utility
Browse files Browse the repository at this point in the history
The functionality of this utility is covered by the xdpdump utility in
xdp-tools.

There's a slight difference in usage as the xdpdump utility's main focus is
to dump packets before or after they are processed by an existing XDP
program. However, xdpdump also has the --load-xdp-program switch, which
will make it attach its own program if no existing program is loaded. With
this, xdp_sample_pkts usage can be converted as:

xdp_sample_pkts eth0
  --> xdpdump --load-xdp-program eth0

To get roughly equivalent behaviour.

Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Link: https://lore.kernel.org/r/20230824102255.1561885-6-toke@redhat.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
  • Loading branch information
tohojo authored and Alexei Starovoitov committed Aug 24, 2023
1 parent eaca21d commit cced069
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 256 deletions.
3 changes: 0 additions & 3 deletions samples/bpf/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ tprogs-y += cpustat
tprogs-y += xdp_adjust_tail
tprogs-y += xdp_fwd
tprogs-y += task_fd_query
tprogs-y += xdp_sample_pkts
tprogs-y += ibumad
tprogs-y += hbm

Expand Down Expand Up @@ -95,7 +94,6 @@ cpustat-objs := cpustat_user.o
xdp_adjust_tail-objs := xdp_adjust_tail_user.o
xdp_fwd-objs := xdp_fwd_user.o
task_fd_query-objs := task_fd_query_user.o $(TRACE_HELPERS)
xdp_sample_pkts-objs := xdp_sample_pkts_user.o
ibumad-objs := ibumad_user.o
hbm-objs := hbm.o $(CGROUP_HELPERS)

Expand Down Expand Up @@ -148,7 +146,6 @@ always-y += cpustat_kern.o
always-y += xdp_adjust_tail_kern.o
always-y += xdp_fwd_kern.o
always-y += task_fd_query_kern.o
always-y += xdp_sample_pkts_kern.o
always-y += ibumad_kern.o
always-y += hbm_out_kern.o
always-y += hbm_edt_kern.o
Expand Down
57 changes: 0 additions & 57 deletions samples/bpf/xdp_sample_pkts_kern.c

This file was deleted.

196 changes: 0 additions & 196 deletions samples/bpf/xdp_sample_pkts_user.c

This file was deleted.

0 comments on commit cced069

Please sign in to comment.