Skip to content

Commit

Permalink
[CRYPTO] padlock-sha: TFMs don't need to be static
Browse files Browse the repository at this point in the history
TFMs are local variables. No need to declare them 
static. After all one is enough.

Signed-off-by: Michal Ludvig <michal@logix.cz>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Michal Ludvig authored and herbertx committed Sep 21, 2006
1 parent 5644bda commit 58ec415
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions drivers/crypto/padlock-sha.c
Original file line number Diff line number Diff line change
Expand Up @@ -262,28 +262,28 @@ static struct crypto_alg sha256_alg = {

static void __init padlock_sha_check_fallbacks(void)
{
static struct crypto_tfm *tfm_sha1, *tfm_sha256;
struct crypto_tfm *tfm;

/* We'll try to allocate one TFM for each fallback
* to test that the modules are available. */
tfm_sha1 = crypto_alloc_tfm(sha1_fallback, 0);
if (!tfm_sha1) {
tfm = crypto_alloc_tfm(sha1_fallback, 0);
if (!tfm) {
printk(KERN_WARNING PFX "Couldn't load fallback module for '%s'. Tried '%s'.\n",
sha1_alg.cra_name, sha1_fallback);
} else {
printk(KERN_NOTICE PFX "Fallback for '%s' is driver '%s' (prio=%d)\n", sha1_alg.cra_name,
crypto_tfm_alg_driver_name(tfm_sha1), crypto_tfm_alg_priority(tfm_sha1));
crypto_free_tfm(tfm_sha1);
crypto_tfm_alg_driver_name(tfm), crypto_tfm_alg_priority(tfm));
crypto_free_tfm(tfm);
}

tfm_sha256 = crypto_alloc_tfm(sha256_fallback, 0);
if (!tfm_sha256) {
tfm = crypto_alloc_tfm(sha256_fallback, 0);
if (!tfm) {
printk(KERN_WARNING PFX "Couldn't load fallback module for '%s'. Tried '%s'.\n",
sha256_alg.cra_name, sha256_fallback);
} else {
printk(KERN_NOTICE PFX "Fallback for '%s' is driver '%s' (prio=%d)\n", sha256_alg.cra_name,
crypto_tfm_alg_driver_name(tfm_sha256), crypto_tfm_alg_priority(tfm_sha256));
crypto_free_tfm(tfm_sha256);
crypto_tfm_alg_driver_name(tfm), crypto_tfm_alg_priority(tfm));
crypto_free_tfm(tfm);
}
}

Expand Down

0 comments on commit 58ec415

Please sign in to comment.