Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink where we store the "last used" and "favourite" state #31

Closed
krassowski opened this issue May 17, 2024 · 6 comments · Fixed by #42
Closed

Rethink where we store the "last used" and "favourite" state #31

krassowski opened this issue May 17, 2024 · 6 comments · Fixed by #42
Assignees

Comments

@krassowski
Copy link
Member

Currently this is stored in StateDB; this is persisted with workspace data and works when user changes browser, but sometimes persistence fails and it has an undesirable interaction with switching workspaces. We should consider storing these metadata separately using a different instance of StateDB which is independent of workspaces.

@krassowski
Copy link
Member Author

I can reproduce that after restart of a pod in nebari the "last used" and "favourite" column status gets cleaned.

@krassowski
Copy link
Member Author

There is something very broken with the workspaces on nebari/JupyterHub. A new auto-workspace gets created each time I try to switch to an existing workspace.

@krassowski
Copy link
Member Author

Ah, it seems that JupyterLab prevents opening given workspace if it is already open in any other tab in the browser.

@krassowski
Copy link
Member Author

It seems like storing a JSON file on the server would work well.

@ericdatakelly
Copy link

Ah, it seems that JupyterLab prevents opening given workspace if it is already open in any other tab in the browser.

Does this include cases in which a user restarts a server and there is an old jlab in another tab? For example, I click the nebari icon in the upper left of the jlab workspace and it opens the nebari launcher in another tab. Then I stop my server. Later, or the next day, I want to continue my work, so from the nebari tab I start the jlab server and it opens jlab in the current tab. I now have an old jlab tab and a new jlab tab.

@krassowski
Copy link
Member Author

Does this include cases in which a user restarts a server and there is an old jlab in another tab

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants