Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: introduce near_build_info metric with node’s release info #6680

Merged
merged 4 commits into from
Apr 25, 2022

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Apr 23, 2022

Introduce near_build_info with a constant value 1 which exports
node’s build information as labels. Specifically, release, build and
rust version are exported. See [1] for description how this metric
can be used.

[1] https://www.robustperception.io/exposing-the-software-version-to-prometheus

While at it, set near_node_protocol_version and near_node_db_version
only once (since they are always set to the same value) rather than
doing so each time statistics are printed. Added bonus of this is
that those metrics are now set immediately when node starts rather
than the first time the stats info line is printed in the log.

Issue: #5979

@mina86 mina86 requested a review from a team as a code owner April 23, 2022 17:18
@mina86 mina86 requested a review from jakmeier April 23, 2022 17:18
Introduce near_build_info with a constant value 1 which exports
node’s build information as labels.  Specifically, release, build and
rust version are exported.  See [1] for description how this metric
can be used.

[1] https://www.robustperception.io/exposing-the-software-version-to-prometheus

While at it, set near_node_protocol_version and near_node_db_version
only once (since they are always set to the same value) rather than
doing so each time statistics are printed.  Added bonus of this is
that those metrics are now set immediately when node starts rather
than the first time the stats info line is printed in the log.

Issue: near#5979
@mina86 mina86 changed the title client: introduce near_build_info metric with node’s release info client: introduce near_build_info metric with node’s release info Apr 25, 2022
Copy link
Contributor

@jakmeier jakmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Interesting approach over all, I appreciate that you included the link to explain why it is done this way!

@near-bulldozer near-bulldozer bot merged commit 2feed98 into near:master Apr 25, 2022
@mina86 mina86 deleted the v branch April 25, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants