network: add near_dropped_message_by_type_and_reason_count metric
#6678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add near_dropped_message_by_type_and_reason_count Prometheus metric and delete `near_drop_message_unknown_account`, `near_<msg-type>_dropped` and `near_dropped_messages_count` metrics. The new metric includes all and more information than the previous metrics provided and does so in a more consistent format. This not only improves the metrics but also makes the code simpler by eliminating `peer_messages` hash map.
mm-near
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add near_dropped_message_by_type_and_reason_count Prometheus metric
and delete
near_drop_message_unknown_account,near_<msg-type>_droppedandnear_dropped_messages_countmetrics.The new metric includes all and more information than the previous
metrics provided and does so in a more consistent format.
This not only improves the metrics but also makes the code simpler by
eliminating
peer_messageshash map.