Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Far Future] Make state syncs work with resharding #9756

Closed
gmilescu opened this issue Jun 30, 2023 · 1 comment
Closed

[Far Future] Make state syncs work with resharding #9756

gmilescu opened this issue Jun 30, 2023 · 1 comment
Labels
Node Node team Task

Comments

@gmilescu
Copy link

gmilescu commented Jun 30, 2023

ND-469 created by None

@gmilescu gmilescu added the Node Node team label Oct 18, 2023
@nikurt
Copy link
Contributor

nikurt commented Dec 11, 2023

Agreed with @wacban that:

  • It would be a significant effort to make this write
  • After pre-state-root migration completes it's no longer needed.
    The conclusion was to skip this significant project and instead wait until for the pre-state-root migration to complete.

A minor change will be needed to how requests for state header or for state parts are interpreted. The nodes will need to assume that the ShardId in the request (or even better ShardUId) corresponds to the new ShardLayout, i.e. to the ShardLayout of the new epoch.

Pre-state-root migration will make it unnecessary to replay the last chunk of a shard, and will simplify the interaction of state sync and resharding.

@nikurt nikurt closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Node Node team Task
Projects
None yet
Development

No branches or pull requests

2 participants