Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoch start is not correctly saved #4243

Open
bowenwang1996 opened this issue Apr 20, 2021 · 3 comments
Open

Epoch start is not correctly saved #4243

bowenwang1996 opened this issue Apr 20, 2021 · 3 comments
Labels
A-chain Area: Chain, client & related C-bug Category: This is a bug T-core Team: issues relevant to the core team

Comments

@bowenwang1996
Copy link
Collaborator

bowenwang1996 commented Apr 20, 2021

Currently we save epoch start whenever the block is the first block of an epoch

self.save_epoch_start(
but this is not necessarily correct because there could be a fork and the fork can overwrite the epoch start on the canonical chain, which would affect the rpc output for validators endpoint.

@bowenwang1996 bowenwang1996 added the A-chain Area: Chain, client & related label Apr 20, 2021
@bowenwang1996 bowenwang1996 added C-bug Category: This is a bug T-core Team: issues relevant to the core team labels Jun 28, 2021
@stale
Copy link

stale bot commented Sep 27, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Sep 27, 2021
@stale
Copy link

stale bot commented Dec 27, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Dec 27, 2021
@stale
Copy link

stale bot commented Mar 29, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-chain Area: Chain, client & related C-bug Category: This is a bug T-core Team: issues relevant to the core team
Projects
None yet
Development

No branches or pull requests

2 participants