Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store bool in ProcessingDoneTracker&Waiter #11486

Open
Longarithm opened this issue Jun 5, 2024 · 0 comments
Open

Store bool in ProcessingDoneTracker&Waiter #11486

Longarithm opened this issue Jun 5, 2024 · 0 comments
Labels
C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. C-housekeeping Category: Refactoring, cleanups, code quality

Comments

@Longarithm
Copy link
Member

Without it it's impossible to propagate the result of worker to waiter, if it exists:

nearcore/tools/state-viewer/src/latest_witnesses.rs

Line 148 in 43c04fb

println!("Validation finished. Use `RUST_LOG=debug` to see validation result");

Arc<OnceCell<bool>> is probably enough.

cc @jancionear
@Longarithm Longarithm added C-housekeeping Category: Refactoring, cleanups, code quality C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. labels Jun 5, 2024
@github-actions github-actions bot mentioned this issue Jul 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Longarithm