Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tests replased with one script in examples CI #318

Merged
merged 5 commits into from
Dec 5, 2022

Conversation

volovyks
Copy link
Collaborator

@volovyks volovyks commented Dec 4, 2022

We are forgetting to add new tests to CI, let's simplify logic a bit.

@volovyks
Copy link
Collaborator Author

volovyks commented Dec 4, 2022

@itegulov after the merge of ABI I noticed that some tests are failing locally (tests that were not added to the CI). Can you please check what is wrong with them?

@itegulov
Copy link
Contributor

itegulov commented Dec 5, 2022

#322 should resolve the ABI generation errors

@volovyks volovyks marked this pull request as ready for review December 5, 2022 09:32
@volovyks volovyks requested a review from ailisp as a code owner December 5, 2022 09:32
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me!

@volovyks volovyks merged commit cf94b8b into develop Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants