feat(cli): new subcommands #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
another option is to export and/or move the funcitons called in previously - this was marked as a draft - but the point of this pr is to have a discussion so i moved it back to |
waynenilsen
force-pushed
the
wayne/extract-command-example
branch
from
bbc986f
to
dd6f02f
Compare
|
It's a great idea @waynenilsen ! I think we want to have a command for all the steps of the build process + one command that will run the pipeline ( |
|
yes i can take care of it |
waynenilsen
force-pushed
the
wayne/extract-command-example
branch
4 times, most recently
from
1aaac6f
to
de9a81f
Compare
waynenilsen
changed the title
### Problem Statement We may want to use parts of this build system with parts of our own build system. I may have use of using my own build script to call rollup and tsc. ### Solution To start this conversation I suggest we make new subcommands for validating and doing other things step-by-step. This is somewhat designed as a sketch to gather feedback and see if you are interested in this kind of work. ### How has this been tested? starting to manually run some of the tests that run in CI noticed a bug something going on with CI build was not working for some reason --- [related issue](near#280)
waynenilsen
force-pushed
the
wayne/extract-command-example
branch
from
de9a81f
to
dff56bc
Compare
ailisp
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
We may want to use parts of this build system with parts of our own build system. I may have use of using my own build script to call rollup and tsc.
Solution
To start this conversation I suggest we make new subcommands for validating and doing other things step-by-step. This is somewhat designed as a sketch to gather feedback and see if you are interested in this kind of work.
How has this been tested?
ok I tested out with my contract, this should work fine, will take another look at unit tests
related issue