-
Notifications
You must be signed in to change notification settings - Fork 6
Bump jsonrpclib #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump jsonrpclib #210
Conversation
Replace jsoniter with circe in tracer
Bump jsonrpclib
| import io.circe.DecodingFailure | ||
|
|
||
| private[langoustine] object jsonrpcIntegration: | ||
| object jsonrpcIntegration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: needed to make this public so that it can be used in the test.core.testkit class
| ): Option[t.In] = | ||
| for | ||
| js <- scala.util.Try(ujson.read(writeToArray(p))).toOption | ||
| js <- scala.util.Try(ujson.read(writeToArray(p.data))).toOption |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: would it be possible for langoustine to switch from ujson to circe? That would help a lot with all these conversions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keynmol thoughts?
|
tests passed but |
nothing new here, think the repo isn't set up for snapshot publishing. Revert my change from ci.yml and it'll go away. or figure out what's missing :) |
I think the secrets are simply not visible in the job due to running in a fork. @keynmol grant us some restricted write access please? :) |
Co-authored-by: Jakub Kozłowski <kubukoz@gmail.com>
No description provided.