Update react-codemirror to the latest version 🚀 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.0.0 of react-codemirror just got published.
The version 1.0.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of react-codemirror.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 48 commits0.
c3ae528v1.0.024528efAdd a changelog, fixes #40f0bdca2Document all props9517265Add name prop, deprecate path with warning6614f62Drop use of React.findDOMNode, fixes #72ca1a1eMerge pull request #94 from k15a/patch-16f66087Adding the autoFocus attribute, closes #1013cecf93Add cursorActivity event, closes #103c896af2Linking to license in readme55fd6efOnly set options if they have changed; fixes #53, closes #93b1b4094Merge pull request #105 from anarchang/master154d226Merge pull request #97 from bvaughn/PropTypes-and-createClass-dep-warnings339b597Do not update the value in codeMirror unless props.value has changed. Otherwise any changes made via the codeMirror API will be overwritten.6d27c7dFixed React 15.5 deprecation warnings34afd8cOptions is a Object without an ArgumentThere are 48 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴