Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ncode/tagit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.3
Choose a base ref
...
head repository: ncode/tagit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.4
Choose a head ref
  • 2 commits
  • 9 files changed
  • 1 contributor

Commits on Dec 26, 2025

  1. add script timeout, integration tests, and cleanup dead code 

    - Add configurable timeout for script execution (default 30s) to prevent
  hangs from misbehaving scripts. Uses exec.CommandContext internally.

- Remove unused excludeTagged() function and its test - dead code from
  previous refactor, functionality already exists in needsTag().

- Remove duplicate comment on getService() function.

- Add integration test suite with 8 tests covering:
  - Basic tag update cycle
  - Tag cleanup
  - Run loop with dynamic tags
  - Real script execution
  - Service not found error handling
  - Empty script output (removes all prefixed tags)
  - Idempotency (no unnecessary Consul writes)
  - Service metadata preservation

- Add docker-compose.test.yml with Consul 1.20 for local testing

- Add Makefile with targets: test, test-integration, consul-up/down

- Update CI workflow to run integration tests with Consul service container
    @ncode
    ncode committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    091044c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #23 from ncode/juliano/updates_and_integration 

    add script timeout, integration tests, and cleanup dead code
    @ncode
    ncode authored Dec 26, 2025
    Configuration menu
    Copy the full SHA
    d8fd2ca View commit details
    Browse the repository at this point in the history
Loading