-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would it be possible to "allow updates only for drafts and prereleases"? #219
Comments
Hmm I think I understand the usecase but could you use
The primary use case of the action is really to generate a release from a tag update. Generating a tag & subsequent release from a commit is a secondary use case (both in terms of the action & the Github API it relies upon). Therefor, I'm hesitant to default the commit to anything other than no value, since by default the action should use the tag if a tag-push triggered it. There are other issues with using the current commit. Github will only create the tag & release once. So if you push another commit with the same tag it will do nothing. |
allowUpdate won't help, the workflow should be allowed to update drafts, but not a release that "has shipped". Is it really so rare to use release drafts to store release candidates for things like installers, extensions, etc? And if the RC needs some fixes - to keep updating the draft until the binaries are stable enough for a release, and then ship and convert the draft to a release? I am about to use the github API to verify the state of the release, and probably use git to push the moved tag. |
I hit the same issue, but for a different reason. I forgot to update the version of my build, so when I went to run the new release build it automatically overwrote an existing release of that particular version. IMO, once a release is Published, it should be immutable. |
Well for me, when I create a release, there are sometimes where one would like to be able to "service" them. |
Added |
Thank you! |
This is the release cycle for one of my projects. I have multiple packages in a monorepo. For the release of any of the packages a new release branch is created and release dispatch workflow is triggered:
This plugin works really well, from my point of view, there only two things that are coming a bit short:
The text was updated successfully, but these errors were encountered: