Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP CE/CloudSQL can't run with multiple threads #166

Closed
Aboisier opened this issue Feb 10, 2019 · 3 comments
Closed

GCP CE/CloudSQL can't run with multiple threads #166

Aboisier opened this issue Feb 10, 2019 · 3 comments
Assignees
Labels
bug Something isn't working component-provider-gcp Affects GCP provider

Comments

@Aboisier
Copy link
Contributor

Aboisier commented Feb 10, 2019

In computeengine.py and cloudsql.py (will soon be merged with PR #164 ) need to hardcode the thread config to 1, otherwise, we get SSL errors.

Repro steps:

  • Have more than one resource (eg. 2 vms, or 2 cloud SQL instances)
  • Start a scan
  • You should see errors in the console, or sometimes it hangs indefinitely

Here's different errors I got:

  • [SSL: BLOCK_CIPHER_PAD_IS_WRONG] block cipher pad is wrong (_ssl.c:2217)Failed to fetch backups for SQL instance xxxxxxxx: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:2217)
  • python SSL: WRONG_VERSION_NUMBER
@Aboisier Aboisier added bug Something isn't working component-provider-gcp Affects GCP provider labels Feb 10, 2019
@x4v13r64
Copy link
Collaborator

Yep, this is an odd one. Will either require diving into the API's implementation or maybe wait until Google does a decent job with their own libraries...

@x4v13r64 x4v13r64 changed the title Fix GCP multithreading problem Fix GCP service multithreading issue Feb 11, 2019
@x4v13r64 x4v13r64 changed the title Fix GCP service multithreading issue GCP CE/CloudSQL can't run with multiple threads Mar 8, 2019
@x4v13r64
Copy link
Collaborator

This seems to be the explanation: https://stackoverflow.com/a/37236585

Looking at the following it isn't clear if CE/CloudSQL should now be thread safe:
googleapis/google-cloud-python#1214
googleapis/google-cloud-python#3674

@Remi05
Copy link
Contributor

Remi05 commented Apr 4, 2019

This is fixed in dev since the refactoring was merged!

@Remi05 Remi05 closed this as completed Apr 4, 2019
@Remi05 Remi05 self-assigned this Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component-provider-gcp Affects GCP provider
Projects
None yet
Development

No branches or pull requests

3 participants