Build fails with clang-19: use of undeclared identifier 'See_the_standard_on_proper_argument_type_for_ctype_functions'

[yurivict]

In file included from /wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/src/corelib/test/test_trial_fail.cpp:38:
In file included from /wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/include/corelib/error_codes.hpp:38:
In file included from /wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/include/corelib/ncbidiag.hpp:42:
In file included from /wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/include/corelib/ncbi_stack.hpp:35:
In file included from /wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/include/corelib/ncbistre.hpp:39:
/wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/include/corelib/ncbictype.hpp:73:1: error: use of undeclared identifier 'See_the_standard_on_proper_argument_type_for_ctype_functions'
   73 | NCBI_DEFINE_CTYPE_FUNC(toupper)
      | ^
/wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/include/corelib/ncbictype.hpp:57:16: note: expanded from macro 'NCBI_DEFINE_CTYPE_FUNC'
   57 |         return See_the_standard_on_proper_argument_type_for_ctype_functions(c); \
      |                ^
/wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/src/corelib/test/test_trial_fail.cpp:109:5: note: in instantiation of function template specialization 'std::toupper<double>' requested here
  109 |     toupper(1.);
      |     ^
1 error generated.

log

Version: 28.0.9
FreeBSD 15

[ucko]

Hi, Yuri.

As in #5, that error is expected and harmless. A look at the log (thanks for attaching it up front!) indicates why the build wound up failing:

In file included from /wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/src/util/diff/diff.cpp:36:
In file included from /wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/src/util/diff/dtl/dtl/dtl.hpp:44:
/wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/src/util/diff/dtl/dtl/Diff.hpp:166:27: error: cannot assign to non-static data member within const member function 'enableTrivial'
  166 |             this->trivial = true;
      |             ~~~~~~~~~~~~~ ^
/wrkdirs/usr/ports/biology/ncbi-cxx-toolkit/work/ncbi-cxx-toolkit-public-release-28.0.9/src/util/diff/dtl/dtl/Diff.hpp:165:14: note: member function 'dtl::Diff::enableTrivial' is declared const here
  165 |         void enableTrivial () const {
      |         ~~~~~^~~~~~~~~~~~~~~~~~~~~~

We've applied @kemin711's fix for that error from #10 to our trunk and should be able to get it into subsequent 28.0.x releases; copying @vladimir-ivanov-ncbi accordingly.

[yurivict]

I'll wait for the next release.

[ucko]

I'll wait for the next release.

Good plan; as I suspected, you'll need a few other small changes.

[kemin711]

thanks for all the good work. Kemin Zhou 510 862-2276 On Tuesday, November 5, 2024 at 11:48:02 AM PST, Aaron Ucko ***@***.***> wrote: I'll wait for the next release. Good plan; as I suspected, you'll need a few other small changes. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[ucko]

28.0.11 should build fine in release mode. (In debug mode, there's still one assertion that will fail to compile; @tlk00, please do take a look when you get a chance.)

[kemin711]

Anyway, I got it compiled successfully thanks for all the good work