[MAINT] Dont require pybind + test python 3.12#81
Merged
nbara merged 7 commits intonbara:masterfrom Nov 19, 2024
Merged
Conversation
Contributor
Author
|
... okay for me to update CIs to use Python 3.12 in this PR as well? |
larsoner
commented
Nov 19, 2024
Owner
absolutely |
larsoner
commented
Nov 19, 2024
larsoner
commented
Nov 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 81.83% 82.86% +1.02%
==========================================
Files 24 25 +1
Lines 2637 2813 +176
==========================================
+ Hits 2158 2331 +173
- Misses 479 482 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Contributor
Author
|
Ready for review/merge from my end. Token can be added whenever you want. It actually seems to be working without it, maybe because this is a personal repo not an org repo? Not sure 🤷 |
Owner
|
Thanks @larsoner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think a requirement on
pybind11might have been errantly added in #68. Perhaps a copy-paste error from adapting another project's pyproject.toml? I don't see it used anywhere but maybe I missed it...Feel free to close if I'm wrong, this is basically a question-as-PR, I am working on a conda-forge recipe and was surprised to see pybind11 in the host reqs.