schema: read_repair_chance

Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>

cql3/statements/cf_prop_defs.hh

@@ -165,9 +165,11 @@ public:
         if (has_property(KW_COMMENT)) {
             builder.set_comment(get_string(KW_COMMENT, ""));
         }
-#if 0
-        cfm.readRepairChance(getDouble(KW_READREPAIRCHANCE, cfm.getReadRepairChance()));
-#endif
+
+        if (has_property(KW_READREPAIRCHANCE)) {
+            builder.set_read_repair_chance(get_double(KW_READREPAIRCHANCE, builder.get_read_repair_chance()));
+        }
+
         if (has_property(KW_DCLOCALREADREPAIRCHANCE)) {
             builder.set_dc_local_read_repair_chance(get_double(KW_DCLOCALREADREPAIRCHANCE, builder.get_dc_local_read_repair_chance()));
         }

db/legacy_schema_tables.cc

@@ -1038,7 +1038,9 @@ future<> save_system_keyspace_schema() {
         m.set_clustered_cell(ckey, "max_index_interval", table->max_index_interval(), timestamp);
 #if 0
         adder.add("memtable_flush_period_in_ms", table.getMemtableFlushPeriod());
-        adder.add("read_repair_chance", table.getReadRepairChance());
+#endif
+        m.set_clustered_cell(ckey, "read_repair_chance", table->read_repair_chance(), timestamp);
+#if 0
         adder.add("speculative_retry", table.getSpeculativeRetry().toString());
 
         for (Map.Entry<ColumnIdentifier, Long> entry : table.getDroppedColumns().entrySet())
@@ -1258,9 +1260,10 @@ future<> save_system_keyspace_schema() {
 #endif
         builder.set_is_dense(is_dense);
 
-#if 0
-        cfm.readRepairChance(result.getDouble("read_repair_chance"));
-#endif
+        if (table_row.has("read_repair_chance")) {
+            builder.set_read_repair_chance(table_row.get_nonnull<double>("read_repair_chance"));
+        }
+
         if (table_row.has("local_read_repair_chance")) {
             builder.set_dc_local_read_repair_chance(table_row.get_nonnull<double>("local_read_repair_chance"));
         }

schema.hh

@@ -175,6 +175,7 @@ private:
         cf_type _type = cf_type::standard;
         int32_t _gc_grace_seconds = 864000;
         double _dc_local_read_repair_chance = 0.1;
+        double _read_repair_chance = 0.0;
         int32_t _min_compaction_threshold = 4;
         int32_t _max_compaction_threshold = 32;
         int32_t _min_index_interval = 128;
@@ -282,6 +283,10 @@ public:
         return _raw._dc_local_read_repair_chance;
     }
 
+    double read_repair_chance() const {
+        return _raw._read_repair_chance;
+    }
+
     int32_t min_compaction_threshold() const {
         return _raw._min_compaction_threshold;
     }

schema_builder.hh

@@ -68,6 +68,14 @@ public:
         return _raw._dc_local_read_repair_chance;
     }
 
+    void set_read_repair_chance(double chance) {
+        _raw._read_repair_chance = chance;
+    }
+
+    double get_read_repair_chance() {
+        return _raw._read_repair_chance;
+    }
+
     void set_min_compaction_threshold(int32_t t) {
         _raw._min_compaction_threshold = t;
     }