Fix failing to call mvn or gradle at MAVEN_HOME, GRADLE_HOME respectively in Windows (Resolves #975) #998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two major factors causing this bug.
System.getenv()
on initializing enums was failed on Windows.oshi.util.ExecutingCommand.runNative()
was failed on Windows due to Linux-specific command scripts.Changes
System.getenv()
after initializing.com.sun.jna.Platform.isWindows()
.Since
com.sun.jna.Platform
sets the static values of current OS on start, no needed to callSystem.getProperty("os.name")
again.But considered that the dependency including
com.sun.jna.Platform
may be removed in future, it could be the best option to check by callingSystem.getProperty("os.name")
.