Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'InnerSpec.keys()' Method with Collection Parameter Support #934

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

songkg7
Copy link
Contributor

@songkg7 songkg7 commented Feb 26, 2024

Summary

Supports collection type as a parameter to InnerSpec.keys(), and a few other method like this.

related: resolve #679

(Optional): Description

add method as follow:

public InnerSpec keys(Collection<?> keys) {
	keys.forEach(this::key())
	return this;
}

However, since the keys() method currently takes an Object as a parameter, I think we should approach method overloading very carefully.

How Has This Been Tested?

I written test code that takes a list as a parameter.

Is the Document updated?

No

@SooKim1110
Copy link
Contributor

Thanks for your contribution!
If you don't mind, it would be great to have a similar method that accepts a collection as a parameter for values() and entries().

@songkg7 songkg7 requested a review from SooKim1110 February 26, 2024 06:37
@songkg7 songkg7 changed the title feat: 'InnerSpec.keys()' Method with Collection Parameter Support Add 'InnerSpec.keys()' Method with Collection Parameter Support Feb 26, 2024
@SooKim1110 SooKim1110 merged commit 6a52bec into naver:main Feb 26, 2024
8 checks passed
@songkg7 songkg7 deleted the songkg7-innerspec-keys-for-collection branch February 26, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'InnerSpec.keys()' Method with Collection Parameter Support
2 participants