Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x/sys and etcd/bbolt modules to support Risc-V #891

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Update x/sys and etcd/bbolt modules to support Risc-V #891

merged 1 commit into from
Jul 29, 2019

Conversation

carlosedp
Copy link
Contributor

Signed-off-by: CarlosEDP me@carlosedp.com

Updating projects using libraries that were recently updated to support Risc-V architecture. This is required to build OpenFaaS on the new architecture.

Go upstream work is tracked on: golang/go#27532

Risc-V software support tracker on carlosedp/riscv-bringup

@coveralls
Copy link

coveralls commented Jul 29, 2019

Coverage Status

Coverage increased (+0.05%) to 91.979% when pulling ab042d0 on carlosedp:riscv64 into 0d16836 on nats-io:master.

@carlosedp
Copy link
Contributor Author

I found out a problem on this, after running GO111MODULE=on go mod tidy && GO111MODULE=on go mod vendor, the go.mod gets the module github.com/nats-io/go-nats v0.0.0-00010101000000-000000000000 // indirect but this gives me an error on building:

➜ go build .
go: github.com/nats-io/nats.go@v1.8.1 used for two different module paths (github.com/nats-io/go-nats and github.com/nats-io/nats.go)

@kozlovic
Copy link
Member

We don't want to add dependencies for tests at this time. I skip the tidy part. Also, not sure why this added the dependency on gnatsd/go-nats. We have updated code base to avoid that...
At any rate, I don't think we want to force Go 1.13 as a dependency at this point.

@carlosedp
Copy link
Contributor Author

Thanks, I'll just update the modules and avoid tidy to push the PR. Sorry about the 1.13 line, my bad.

Signed-off-by: CarlosEDP <me@carlosedp.com>
@carlosedp
Copy link
Contributor Author

Passed, thanks for the heads-up on "tidy" @kozlovic. It was really messing things up.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 3625a0b into nats-io:master Jul 29, 2019
@kozlovic
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants