Skip to content

Commit bb4505e

Browse files
committed
Drop useless MiscTestUtils
1 parent 8af602f commit bb4505e

11 files changed

+45
-85
lines changed

Core/src/test/java/com/nativelibs4java/opencl/AbstractCommon.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import org.junit.Before;
99
import org.junit.BeforeClass;
1010

11-
import com.nativelibs4java.test.MiscTestUtils;
1211
import java.util.ArrayList;
1312
import java.util.List;
1413
import org.junit.After;
@@ -27,12 +26,6 @@ public abstract class AbstractCommon {
2726
CLQueue queue;
2827
CLDevice device;
2928
CLImageFormat[] formatsRead2D, formatsRead3D, formatsWrite2D, formatsWrite3D, formatsReadWrite2D, formatsReadWrite3D;
30-
/*
31-
@BeforeClass
32-
public static void setup() {
33-
MiscTestUtils.protectJNI();
34-
}
35-
*/
3629

3730
static boolean listedPlatforms;
3831

@@ -68,4 +61,4 @@ public void cleanup() {
6861
platform.release();
6962
}
7063
*/
71-
}
64+
}

Core/src/test/java/com/nativelibs4java/opencl/BinaryKernelTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
import org.bridj.Pointer;
1010
import static org.bridj.Pointer.*;
11-
import com.nativelibs4java.test.MiscTestUtils;
1211
import java.util.List;
1312
import org.junit.Ignore;
1413
import org.junit.runners.Parameterized;
@@ -81,4 +80,4 @@ public void cachingTest() {
8180
sp2.setCached(true); // set to false and it works
8281
sp2.createKernel("sub");
8382
}
84-
}
83+
}

Core/src/test/java/com/nativelibs4java/opencl/BufferTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import org.junit.BeforeClass;
1616
import org.junit.Test;
1717

18-
import com.nativelibs4java.test.MiscTestUtils;
1918
import com.nativelibs4java.util.NIOUtils;
2019
import org.bridj.*;
2120
import java.nio.ByteOrder;

Core/src/test/java/com/nativelibs4java/opencl/ByteOrderHackTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
import org.bridj.Pointer;
1010
import static org.bridj.Pointer.*;
11-
import com.nativelibs4java.test.MiscTestUtils;
1211
import java.util.List;
1312
import org.junit.runners.Parameterized;
1413

Core/src/test/java/com/nativelibs4java/opencl/EventTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
import org.bridj.Pointer;
1010
import static org.bridj.Pointer.*;
11-
import com.nativelibs4java.test.MiscTestUtils;
1211
import java.util.List;
1312
import org.junit.runners.Parameterized;
1413

Core/src/test/java/com/nativelibs4java/opencl/InfoGettersTest.java

Lines changed: 41 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55
package com.nativelibs4java.opencl;
66

7-
import static com.nativelibs4java.test.MiscTestUtils.testGetters;
87
import static org.junit.Assert.assertFalse;
98

109
import java.util.logging.Level;
@@ -13,8 +12,6 @@
1312
import org.junit.Before;
1413
import org.junit.BeforeClass;
1514

16-
import com.nativelibs4java.test.MiscTestUtils;
17-
1815
/**
1916
*
2017
* @author ochafik
@@ -124,4 +121,45 @@ public void CLEventGetters() {
124121
public void CLSamplerGetters() {
125122
testGetters(createSampler());
126123
}
124+
125+
public static void testGetters(Object instance) {
126+
if (instance == null)
127+
return;
128+
Logger log = Logger.getLogger(instance.getClass().getName());
129+
for (Method m : instance.getClass().getDeclaredMethods()) {
130+
if (Modifier.isStatic(m.getModifiers()))
131+
continue;
132+
if (!Modifier.isPublic(m.getModifiers()))
133+
continue;
134+
if (m.getParameterTypes().length != 0)
135+
continue;
136+
137+
String name = m.getName();
138+
if (name.contains("ProfilingCommand"))
139+
continue;
140+
141+
boolean isToString = name.equals("toString");
142+
if (name.startsWith("get") && name.length() > 3 ||
143+
name.startsWith("has") && name.length() > 3 ||
144+
name.startsWith("is") && name.length() > 2 ||
145+
isToString && !Modifier.isPublic(m.getDeclaringClass().getModifiers()))
146+
{
147+
String msg = "Failed to call " + m;
148+
try {
149+
m.invoke(instance);
150+
} catch (IllegalAccessException ex) {
151+
if (!isToString)
152+
log.log(Level.WARNING, msg, ex);
153+
} catch (InvocationTargetException ex) {
154+
Throwable cause = ex.getCause();
155+
if (!(cause instanceof UnsupportedOperationException)) {
156+
log.log(Level.SEVERE, msg, ex.getCause());
157+
assertFalse(msg, true);
158+
}
159+
} catch (Exception ex) {
160+
log.log(Level.SEVERE, msg, ex);
161+
}
162+
}
163+
}
164+
}
127165
}

Core/src/test/java/com/nativelibs4java/opencl/KernelTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public <T> Object testArrayArg(String type, Object array, Class<T> targetType) {
4343
CLBuffer<Byte> out = context.createByteBuffer(Usage.Output, size * length);
4444
StringBuilder b = new StringBuilder(
4545
"#pragma OPENCL EXTENSION cl_khr_fp64 : enable\n" +
46-
"kernel void f(" + type + length + " arg, global " + type + "* out, long length) {\n");
46+
"kernel void f(constant " + type + length + " arg, global " + type + "* out, long length) {\n");
4747
for (long i = 0; i < length; i++) {
4848
b.append("out[" + i + "] = arg.s" + (i < 10 ? i + "" : ((char)((int)'a' + (i - 10))) + "") + ";\n");
4949
}

Core/src/test/java/com/nativelibs4java/opencl/OpenCL4JavaBasicTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import org.junit.BeforeClass;
1313
import org.junit.Test;
1414

15-
import com.nativelibs4java.test.MiscTestUtils;
1615
import com.nativelibs4java.util.NIOUtils;
1716

1817
public class OpenCL4JavaBasicTest {

Core/src/test/java/com/nativelibs4java/opencl/OpenCL4JavaBenchmarkTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import com.nativelibs4java.opencl.CLTestUtils.Action2;
2020
import com.nativelibs4java.opencl.CLTestUtils.ExecResult;
21-
import com.nativelibs4java.test.MiscTestUtils;
2221

2322
//import com.nativelibs4java.scalacl.*;
2423
/// @see http://ati.amd.com/technology/streamcomputing/intro_opencl.html#simple

Core/src/test/java/com/nativelibs4java/opencl/OverheadTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import org.bridj.Pointer;
1414
import org.bridj.Platform;
1515
import static org.bridj.Pointer.*;
16-
import com.nativelibs4java.test.MiscTestUtils;
1716
import java.util.logging.Level;
1817
import java.util.logging.Logger;
1918

@@ -157,4 +156,4 @@ public void run() {
157156
assertTrue("CLKernel.setArg was supposed not to be more than " + maxSlower + "x slower than hand-optimized version, was " + slowerSetArg + "x slower.", slowerSetArg <= maxSlower);
158157
assertTrue("CLKernel.setArgs was supposed not to be more than " + maxSlower + "x slower than hand-optimized version, was " + slowerSetArgs + "x slower.", slowerSetArgs <= maxSlower);
159158
}
160-
}
159+
}

Core/src/test/java/com/nativelibs4java/test/MiscTestUtils.java

Lines changed: 0 additions & 64 deletions
This file was deleted.

0 commit comments

Comments
 (0)