Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Artwork #140

Closed
zzzzzozzzzz opened this issue Aug 5, 2021 · 1 comment
Closed

Bug: Artwork #140

zzzzzozzzzz opened this issue Aug 5, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@zzzzzozzzzz
Copy link

Bug Report

Current Behavior
The tool embeds the 'large' image regardless of the size set in the configuration file.

streamrip Configuration File (extracts):

[artwork]
# Write the image to the audio file
embed = true 
# The size of the artwork to embed. Options: thumbnail, small, large, original.
# "original" images can be up to 30MB, and may fail embedding. 
# Using "large" is recommended.
size = "thumbnail"
# Both of these options limit the size of the embedded artwork. If their values
# are larger than the actual dimensions of the image, they will be ignored.
max_width = 999999
max_height = 999999
# Save the cover image at the highest quality as a seperate jpg file
keep_hires_cover = true

Environment

  • streamrip version: 0488427
  • Python version: 3.9
  • OS: Linux
@zzzzzozzzzz zzzzzozzzzz added the bug Something isn't working label Aug 5, 2021
@nathom nathom closed this as completed in fffbcec Aug 13, 2021
@nathom
Copy link
Owner

nathom commented Aug 14, 2021

Fixed in v1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants