Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v-date-picker collision with native component #1491

Open
MarkusWollny opened this issue Aug 2, 2024 · 0 comments
Open

v-date-picker collision with native component #1491

MarkusWollny opened this issue Aug 2, 2024 · 0 comments

Comments

@MarkusWollny
Copy link

Vuetify released a native v-date-picker component under the same spelling in 3.4 back in November 2023, see https://vuetifyjs.com/en/getting-started/release-notes/?version=v3.4.0

Anyone using v-date-picker from v-calendar in an application built on Vuetify would now need to import the component under a new alias and adjust their use of the component like so:

import 'v-calendar/dist/style.css'
import { DatePicker as VCalendarDatePicker } from 'v-calendar'

... and then instead of <v-date-picker> use <v-calendar-date-picker> .

If the component is not remapped to a new name, the application will throw an error comparing.getDate is not a function, as the native v-date-picker from Vuetify would be invoked, which will definitely not be intended.

I am aware that this is less than ideal, but I assume that the adoption of Vuetify for Vue 3 projects is fairly significant, so I suggest deprecating <v-date-picker> in the current version and encourage switching to something like <v-calendar-date-picker>. This would also have the advantage that developers taking over existing code would obviously more easily notice that this component is actually coming from the v-calendar package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant