Merge branch 'master' into fix/streams-example

Author: Terkwood

README.md

@@ -91,6 +91,10 @@ To build the docs:
 
     $ make docs
 
+We encourage you to run `clippy` prior to seeking a merge for your work.  The lints can be quite strict.  Running this on your own workstation can save you time, since Travis CI will fail any build that doesn't satisfy `clippy`:
+
+    $ cargo clippy --all-features --all --tests --examples -- -D clippy::all -D warnings
+
 To run fuzz tests with afl, first install cargo-afl (`cargo install -f afl`),
 then run:
 

src/cmd.rs

@@ -1,4 +1,4 @@
-use std::io;
+use std::{fmt, io};
 
 use crate::connection::ConnectionLike;
 use crate::types::{
@@ -243,9 +243,14 @@ fn write_pipeline(rv: &mut Vec<u8>, cmds: &[Cmd], atomic: bool) {
 
 impl RedisWrite for Cmd {
     fn write_arg(&mut self, arg: &[u8]) {
-        let prev = self.data.len();
-        self.args.push(Arg::Simple(prev + arg.len()));
         self.data.extend_from_slice(arg);
+        self.args.push(Arg::Simple(self.data.len()));
+    }
+
+    fn write_arg_fmt(&mut self, arg: impl fmt::Display) {
+        use std::io::Write;
+        write!(self.data, "{}", arg).unwrap();
+        self.args.push(Arg::Simple(self.data.len()));
     }
 }
 

src/geo.rs

@@ -212,7 +212,7 @@ impl ToRedisArgs for RadiusOptions {
 
         if let Some(n) = self.count {
             out.write_arg(b"COUNT");
-            out.write_arg(format!("{}", n).as_bytes());
+            out.write_arg_fmt(n);
         }
 
         match self.order {

src/types.rs

@@ -590,12 +590,21 @@ impl InfoDict {
 pub trait RedisWrite {
     /// Accepts a serialized redis command.
     fn write_arg(&mut self, arg: &[u8]);
+
+    /// Accepts a serialized redis command.
+    fn write_arg_fmt(&mut self, arg: impl fmt::Display) {
+        self.write_arg(&arg.to_string().as_bytes())
+    }
 }
 
 impl RedisWrite for Vec<Vec<u8>> {
     fn write_arg(&mut self, arg: &[u8]) {
         self.push(arg.to_owned());
     }
+
+    fn write_arg_fmt(&mut self, arg: impl fmt::Display) {
+        self.push(arg.to_string().into_bytes())
+    }
 }
 
 /// Used to convert a value into one or multiple redis argument