-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer works for youtube videos #5
Comments
Could you provide more details and a minimum reproducible example? The embed Youtube video on the demo page seems to still be working |
Hello, It does work as long as you don't insert any linked links. This problem is presented on both github pages and up-to-date jekyll. If you use markdown to place linked links your links will be parsed as raw text. EDIT: Haven't tested for inline style links |
I had an issue with the template containing the following: |
So the fix was changing
to
Does anyone know a reason why that fixes it? If it seems to work, I'll patch it in |
What about CORS restrictions in chrome? htaccess
Header Response
Chrome Devtools |
Sorry I've never encountered that CORS error. My guess is that you haven't turned on link sharing for your Google drive video. Take a look at the embed Google Drive section. |
@nathancy had already done that. |
Update for new readersThis works for YouTube as of November 2023. In case its relevant, if you have several videos on the same page you can use the following method Front matter
Embed include:
The above method can be used for Vimeo player too. I haven't tested other players/hosts.
|
As of today with the default settings for github pages youtube videos break the markup.
The text was updated successfully, but these errors were encountered: