Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefixes tagged with blackhole get rejected due to out of bounds #208

Open
accuris-infrastructure opened this issue Jan 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@accuris-infrastructure
Copy link

Describe the bug
Pathvector rejects routes with a length of /128 or /32 from peers when tagged with the blackhole community, when filter-prefix-length and allow-blackhole-community are enabled on the session. It should be possible to allow these prefix lengths through the filters when tagged with the blackhole community, as some carriers only accept /32s and /128s for RTBH purposes.

Environment

~# pathvector version
Pathvector 6.3.2
Built c35220bf121f366ff05a51d93c6236e8c324d682 on 2023-06-11T07:03:14Z
No plugins
BIRD: ready.
~# cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian

To Reproduce
Steps to reproduce the behavior:

  1. Configure a session with filter-prefix-length and allow-blackhole-community enabled on the peer.
  2. Advertise a prefix with a length of either /32 or /128 to the peer with the above 2 settings enabled and the blackhole community tagged on export
  3. See error
bird: REJECTED [out of bounds (48 > len > 12)] pfx 2602:XXXX:XXX::1/128 session USER_ASXXXXX_v6 path (path XXXXX) pathlen 1 origin XXXXX

I suspect that this is due to the order in which the filters get processed in the generated BIRD config:

import filter {
...
            reject_out_of_bounds_routes();
            bgp_local_pref = 200; # pathvector:localpref
            process_blackholes();
...
            accept;
        };

Expected behavior
Blackhole gets processed as normal.

Actual behavior
Blackhole gets rejected due to being out of bounds.

@accuris-infrastructure accuris-infrastructure added the bug Something isn't working label Jan 10, 2024
@accuris-infrastructure
Copy link
Author

Also worth noting that even with the community being tagged, if you also have RPKI and IRR filtering enabled on the peer it also rejects the announcement due to being invalid or outside the prefix list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant