Add checked exceptions for run
#3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can provide similar behavior to `Control.Monad.Except.Checked` except in the world of `run`. The general idea is the same though: use polymorphic variants to encode exceptions and handle appropriately. This is mostly a copy of `Control.Monad.Except.Checked`. There's been some massaging of types and values to make things line up.
joneshf
commented
May 9, 2018
| . RowToList handlers rl | ||
| ⇒ VariantMatchCases rl excHandled (Run (except :: EXCEPTV excOut | r) a) | ||
| ⇒ Union excHandled excOut excIn | ||
| ⇒ Union r m (except :: EXCEPTV excOut | r) |
There was a problem hiding this comment.
I'm unsure about this bit of the type.
The expand below forced this constraint. Is it right? Maybe there's another way to do the same thing?
There was a problem hiding this comment.
Is the expand necessary if you account for duplicate labels? That is, something like
...
→ Run (except :: EXCEPTV excIn, except :: EXCEPTV excOut | r) a
→ Run (except :: EXCEPTV excOut | r) aThere was a problem hiding this comment.
Looks like dropping the expand and changing to the signature you suggest allows dropping the Union r m (except :: EXCEPTV excOut | r) constraint.
Which would you prefer: with expand and constraint, or without?
|
@natefaubion thoughts? |
|
Sorry about this. Apparently I'm not automatically watching my repos, so I've gotten no notifications 😆 |
|
No worries, I do the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on slack. This is mostly copy/paste. Let me know if something should change.