Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overScrollHorizontal ignored ? #230

Open
boldijar opened this issue Jan 26, 2023 · 1 comment
Open

overScrollHorizontal ignored ? #230

boldijar opened this issue Jan 26, 2023 · 1 comment
Labels

Comments

@boldijar
Copy link

boldijar commented Jan 26, 2023

How do I?

 <com.otaliastudios.zoom.ZoomLayout
        android:id="@+id/zoom"
        app:overScrollHorizontal="false"
        app:overScrollVertical="false"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:background="@color/black">

        <org.videolan.libvlc.util.VLCVideoLayout
            android:id="@+id/view_vlc_layout"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            app:layout_constraintBottom_toBottomOf="parent"
            app:layout_constraintEnd_toEndOf="parent"
            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toTopOf="parent" />

    </com.otaliastudios.zoom.ZoomLayout>

As you can see here I’ve added

app:overScrollHorizontal="false"
        app:overScrollVertical=“false"

I’m trying to never let the content overscroll, and it works vertically, but doesn’t work horizontally. (I’m in landscape orientation)

Notice here the black bars left, where I can move the child view. It should stop before showing the black bars.

image

When I’m using portrait orientation the vertical overscroll property is ignored and I can scroll a lot

image

Version used

implementation 'com.github.tbouron.shakedetector:library:1.0.0@aar’
@markusressel
Copy link
Collaborator

markusressel commented Jan 29, 2023

Does the overScrollHorizontal work in portrait?
Is this limited to the landscape orientation not working as expected?

EDIT:
Sorry I didn't read correctly.
Yeah seems like there is a bug with screen rotation which mixes up vertical and horizontal limits, and maybe even a second one not applying the vertical one correctly.

Sadly the time investment from our side on this project is currently very limited, however, if you can find a fix and open a PR yourself we can review and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants