Adding sort_keys #17
Merged
Adding sort_keys #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eereiter
approved these changes
Jul 20, 2023
Collaborator
|
We're in need of this feature at GES DISC - I had put in a request to be maintainer to help approve PRs months ago for python-cmr but it was never approved. Can I nudge @frankinspace to review/approve? |
stephenykp
approved these changes
Jul 26, 2023
frankinspace
requested changes
Jul 26, 2023
Collaborator
frankinspace
left a comment
frankinspace
left a comment
There was a problem hiding this comment.
@eudoroolivares2016 Can you please add an entry to the changelog (under the Unreleased header create a Added section and describe the new feature). Also, can you add a note in the readme about sort keys.
Thank you for the contribution!
frankinspace
approved these changes
Jul 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor spelling fixes
adds sort keys for granules will do collections some other time
testing:
start up python in the repo
from cmr import CollectionQuery, GranuleQuery, ToolQuery, ServiceQuery, VariableQueryimport jsonapi = GranuleQuery()
api.parameters(short_name="OMNO2", version="003", provider='GES_DISC', sort_key='-start_date')print(json.dumps(granules, indent=1))
ensure that the returned granules are sorted by the sort_key