Skip to content

Conversation

@sliu008
Copy link
Contributor

@sliu008 sliu008 commented Mar 3, 2022

  • Change tokens from being in url to added to headers in api requests to support launchpad tokens

@sliu008 sliu008 requested a review from frankinspace March 3, 2022 18:00
Copy link
Collaborator

@frankinspace frankinspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think EDL tokens need Bearer xxxx where Launchpad tokens are just the token value?

@sliu008
Copy link
Contributor Author

sliu008 commented Mar 3, 2022

I think EDL tokens need Bearer xxxx where Launchpad tokens are just the token value?

didn't seem to matter if it was and edl or launchpad token when using the "Authorization" headers, ill ask in the cmr channel to confirm from testing seem to work for both.

@frankinspace frankinspace self-requested a review March 3, 2022 18:30
@sliu008 sliu008 merged commit ca610cc into develop Mar 3, 2022
@frankinspace frankinspace deleted the feature/token_headers branch March 3, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants