Skip to content

Recommended lgtm osal issues #327

@avan989

Description

@avan989

Is your feature request related to a problem? Please describe.
Recommended osal issues:

osapi-os-core.h

line 50:
/* #define for enabling floating point operations on a task*/
--
  | This comment appears to contain commented-out code

osapi-module.c

line 319:
/* module_prop->creator = record->creator; */
--
  | This comment appears to contain commented-out code


shared/os-impl.h

typedef enum
--
367 | {
  | In an enumerator list, the = construct should not be used to explicitly initialize members other than the first, unless all items are explicitly initialized.
368 | OS_FILE_FLAG_NONE,
369 | OS_FILE_FLAG_CREATE = 0x01,

posix/osnetwork.c

/*
--
25 | * FIXME: this belongs in the osconfig.h file, really.
26 | */
  | FIXME comment: this belongs in the osconfig.h file, really.
27 | #define OS_NETWORK_SUPPORTS_IPV6

shared/osapi-select.c

/*
--
85 | * FIXME:
86 | * This does not currently increment any refcounts.
87 | * That means a file/socket can be closed while actively inside a
88 | * OS_SelectMultiple() call in another thread.
89 | */
  | FIXME comment

Requester Info
Anh Van, NASA Goddard

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions