Ensure all unit test cases for invalid ID use UNDEFINED plus another value #1052
Description
Is your feature request related to a problem? Please describe.
When checking for proper ID validation, the specific value OS_OBJECT_ID_UNDEFINED must be rejected as it is always invalid. However, the set of values that should be rejected is much larger than this - proper ID validation should only permit a small subset of values to be accepted.
Describe the solution you'd like
In order to confirm that ID values are being validated properly, test cases checking for OS_ERR_INVALID_ID should pass in OS_OBJECT_ID_UNDEFINED as well as some other value, which should be nonzero, but also not in the valid range - to confirm that the implementation is doing the proper validation and not simply checking for equality with OS_OBJECT_ID_UNDEFINED.
Additional context
This came up as part of return/status code validation efforts - test cases are currently inconsistent, some tests are only using OS_OBJECT_ID_UNDEFINED, while some only use UT_OBJID_INCORRECT.
Requester Info
Joseph Hickey, Vantage Systems, Inc.