Merge pull request #903 from jphickey/fix-867-better-espipe-error

astrogeco · web-flow · commit e9e71c73326a · 2021-03-21T23:32:41.000-04:00
Fix #867, better error translation for ESPIPE errno
diff --git a/src/os/portable/os-impl-posix-io.c b/src/os/portable/os-impl-posix-io.c
@@ -138,7 +138,7 @@ int32 OS_GenericSeek_Impl(const OS_object_token_t *token, int32 offset, uint32 w
              * Use a different error code to differentiate from an
              * error involving a bad whence/offset
              */
-            retval = OS_ERR_NOT_IMPLEMENTED;
+            retval = OS_ERR_OPERATION_NOT_SUPPORTED;
         }
         else
         {
diff --git a/src/unit-test-coverage/portable/src/coveragetest-posix-io.c b/src/unit-test-coverage/portable/src/coveragetest-posix-io.c
@@ -84,7 +84,7 @@ void Test_OS_GenericSeek_Impl(void)
 
     /* The seek implementation also checks for this specific pipe errno */
     OCS_errno = OCS_ESPIPE;
-    OSAPI_TEST_FUNCTION_RC(OS_GenericSeek_Impl, (&token, 0, OS_SEEK_END), OS_ERR_NOT_IMPLEMENTED);
+    OSAPI_TEST_FUNCTION_RC(OS_GenericSeek_Impl, (&token, 0, OS_SEEK_END), OS_ERR_OPERATION_NOT_SUPPORTED);
 }
 
 void Test_OS_GenericRead_Impl(void)

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ int32 OS_GenericSeek_Impl(const OS_object_token_t *token, int32 offset, uint32 w`
`138`	`138`	`* Use a different error code to differentiate from an`
`139`	`139`	`* error involving a bad whence/offset`
`140`	`140`	`*/`
`141`		`- retval = OS_ERR_NOT_IMPLEMENTED;`
	`141`	`+ retval = OS_ERR_OPERATION_NOT_SUPPORTED;`
`142`	`142`	`}`
`143`	`143`	`else`
`144`	`144`	`{`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ void Test_OS_GenericSeek_Impl(void)`
`84`	`84`
`85`	`85`	`/* The seek implementation also checks for this specific pipe errno */`
`86`	`86`	`OCS_errno = OCS_ESPIPE;`
`87`		`- OSAPI_TEST_FUNCTION_RC(OS_GenericSeek_Impl, (&token, 0, OS_SEEK_END), OS_ERR_NOT_IMPLEMENTED);`
	`87`	`+ OSAPI_TEST_FUNCTION_RC(OS_GenericSeek_Impl, (&token, 0, OS_SEEK_END), OS_ERR_OPERATION_NOT_SUPPORTED);`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`void Test_OS_GenericRead_Impl(void)`