Merge pull request #1028 from jphickey/fix-1027-bsp-nocancel

Fix #1027, defer cancellation when BSP locked

Author: astrogeco

src/bsp/generic-linux/src/bsp_start.c

@@ -110,6 +110,15 @@ void OS_BSP_Lock_Impl(void)
     {
         BSP_DEBUG("pthread_mutex_lock: %s\n", strerror(status));
     }
+    else
+    {
+        /*
+         * Temporarily Disable/Defer thread cancellation.
+         * Note that OS_BSP_ConsoleOutput_Impl() calls write() which is a cancellation point.
+         * So if this calling task is canceled, it risks leaving the BSP locked.
+         */
+        pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &OS_BSP_GenericLinuxGlobal.AccessCancelState);
+    }
 }
 
 /*----------------------------------------------------------------
@@ -125,6 +134,11 @@ void OS_BSP_Unlock_Impl(void)
     {
         BSP_DEBUG("pthread_mutex_unlock: %s\n", strerror(status));
     }
+    else
+    {
+        /* Restore previous cancelability state */
+        pthread_setcancelstate(OS_BSP_GenericLinuxGlobal.AccessCancelState, NULL);
+    }
 }
 
 /* ---------------------------------------------------------

src/bsp/generic-linux/src/generic_linux_bsp_internal.h

@@ -42,6 +42,7 @@ typedef struct
 {
     bool            EnableTermControl; /**< Will be set "true" when invoked from a TTY device, false otherwise */
     pthread_mutex_t AccessMutex;
+    int             AccessCancelState;
 } OS_BSP_GenericLinuxGlobalData_t;
 
 /*

src/os/shared/src/osapi-task.c

@@ -339,18 +339,10 @@ int32 OS_TaskSetPriority(osal_id_t task_id, osal_priority_t new_priority)
  *-----------------------------------------------------------------*/
 osal_id_t OS_TaskGetId(void)
 {
-    OS_object_token_t token;
-    osal_id_t         task_id;
+    osal_id_t task_id;
 
     task_id = OS_TaskGetId_Impl();
 
-    /* Confirm the task master table entry matches the expected.
-     * If not it means we have some stale/leftover value */
-    if (OS_ObjectIdGetById(OS_LOCK_MODE_NONE, LOCAL_OBJID_TYPE, task_id, &token) != OS_SUCCESS)
-    {
-        task_id = OS_OBJECT_ID_UNDEFINED;
-    }
-
     return (task_id);
 } /* end OS_TaskGetId */
 

src/unit-test-coverage/shared/src/coveragetest-task.c

@@ -197,10 +197,6 @@ void Test_OS_TaskGetId(void)
     UT_SetDefaultReturnValue(UT_KEY(OS_TaskGetId_Impl), idbuf.val);
     objid = OS_TaskGetId();
     OSAPI_TEST_OBJID(objid, ==, idbuf.id);
-
-    UT_SetDefaultReturnValue(UT_KEY(OS_ObjectIdGetById), OS_ERROR);
-    objid = OS_TaskGetId();
-    OSAPI_TEST_OBJID(objid, ==, OS_OBJECT_ID_UNDEFINED);
 }
 
 void Test_OS_TaskGetIdByName(void)