Fix #2040, Improve CFE_SB_IsValidMsgId handler #2041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
If no return value override is set test against CFE_SB_INVALID_MSG_ID
skliper
force-pushed
the
fix2040-isvalidmsgid_stub_improvement
branch
from
3428882 to
a5f27e8
Compare
astrogeco
removed
the
CCB:Ready
skliper
added
the
CCB:Ready
astrogeco
added
CCB:Approved
Contributor
|
CCB:2022-02-01 APPROVED |
This was referenced Feb 3, 2022
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 3, 2022
*cFE v7.0.0-rc4+dev70* nasa/cFE#2041, Improve CFE_SB_IsValidMsgId handler nasa/cFE#2034, Update CodeQL workflow nasa/cFE#2042, Replace CFE_SB_ValueToMsgId(0) with CFE_SB_INVALID_MSG_ID *osal v6.0.0-rc4+dev32* nasa/osal#1209, typesafe definition of osal_id_t *sample_app v1.3.0-rc4+dev9* nasa/sample_app#165, Use preferred UT patterns Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Paul <paulober@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
CFE_SB_IsValidMsgIdhandler default behavior fails if return not set #2040Testing performed
Build/run unit tests, passed.
Used with DS and confirm units under test worked as expected based on valid/invalid MID use.
Expected behavior changes
Handler behaves more like expected
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC