Skip to content

Conversation

@nmullane
Copy link
Contributor

Describe the contribution

Testing performed
Steps taken to test the contribution:

  1. Build CFE and run all functional tests

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • no impact to behavior

System(s) tested on

  • Hardware: PC
  • OS: Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Niall Mullane - GSFC 582 Intern

@nmullane nmullane marked this pull request as ready for review July 29, 2021 18:07
@astrogeco astrogeco added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 3, 2021
@astrogeco astrogeco requested review from skliper and zanzaben August 9, 2021 14:38
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also test for range, should be within maximum allowed. Comment comes from a previous similar test, which I think is still valid here.

@nmullane
Copy link
Contributor Author

nmullane commented Aug 9, 2021

Also test for range, should be within maximum allowed. Comment comes from a previous similar test, which I think is still valid here.

There is an issue for this with an associated branch on my fork that does this, but Gerardo suggested I create a second PR for that once this is merged.
#1760

@astrogeco astrogeco changed the base branch from main to integration-candidate August 9, 2021 21:15
@astrogeco astrogeco merged commit e7166d0 into nasa:integration-candidate Aug 9, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 9, 2021
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 11, 2021
@astrogeco
Copy link
Contributor

CCB:2021-08-11 APPROVED

  • Add call for background wakeup

@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add functional tests for cFE ES Resource ID APIs

4 participants