Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate between circulars within specific circulars pages #2227

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tylerbarna
Copy link
Member

Description

Adds navigation buttons inside specific circular pages to navigate to previous and next circulars. If attempting to navigate to a circular that does not exist, users will be returned to the main circulars page.

Related Issue(s)

Resolves #2226

Testing

Testing for basic navigation:

  1. Navigate to a specific circular
  2. Scroll to bottom of page
  3. Click 'Next Circular' or 'Previous Circular' buttons
  4. Page for next or previous circular should load

Testing for navigation to a nonexistent circular:

  1. Navigate to the most recent circular
  2. Click 'Next Circular'
  3. Main Circulars page should load
  4. Navigate to oldest circular
  5. Click 'Previous Circular'
  6. Main Circulars page should load

adds buttons to navigate to previous and next circular within a given circular page. Does not currently account for circulars that do not follow the integer numbering.
@tylerbarna
Copy link
Member Author

8033408 does not handle instances of non-standard circular IDs, hence the draft status. Also does not indicate when user is navigating back to the main Circulars page when on the oldest or most recent Circular

@lpsinger
Copy link
Member

There are also occasions when Circular IDs increment by more than 1 --- when we have deleted duplicate Circulars, for example.

@tylerbarna tylerbarna closed this Apr 28, 2024
@tylerbarna tylerbarna reopened this Apr 28, 2024
@tylerbarna
Copy link
Member Author

they really should add a confirmation for the close PR button...

@tylerbarna
Copy link
Member Author

I was thinking a bit more about this, and if this were to use some way of maintaining the search context as we had discussed, it would work when navigating from the root archive page to a specific circular, but in cases where there isn't a search context (ie when someone clicks on a direct link to a specific circular from outside GCN), it wouldn't work. It might be more robust to use the URL search parameters to initiate a search when a specific circular page is loaded, though I'm not sure how much overhead it would add to implement the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Open
Development

Successfully merging this pull request may close these issues.

Feature: In-page Navigation Between Circulars
2 participants