chore: Add Version.dtypes, remove import_dtypes_module
#2431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could always just revert the
@FBruzzesi @MarcoGorelli - was wondering if you were able to spot anything semantically different? Ideally so I could add a test that'll warn me when I do that again 😄 UpdateNo closer to knowing what was wrong, but whatever I introduced is no longer there (6d56dc6) |
Tests pass again (a5fca0a) Can we keep it that way?
dangotbanned
changed the title
Version.dtypes, remove import_dtypes_moduleVersion.dtypes, remove import_dtypes_module
FBruzzesi
reviewed
Apr 25, 2025
There was a problem hiding this comment.
Thanks @dangotbanned - Left a tiny comment and maybe some thoughts for your comment
Co-authored-by: Francesco Bruzzesi <42817048+FBruzzesi@users.noreply.github.com>
😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Version.namespace, removeimport_namespace#2425)Checklist
If you have comments or can explain your changes, please do so below