fix(typing): resolve for pyarrow-stubs>=17.18

#2113 (comment)

Author: dangotbanned

narwhals/_arrow/expr.py

@@ -164,7 +164,7 @@ def func(df: ArrowDataFrame) -> Sequence[ArrowSeries]:
                 # again calling `sort_indices`. `ArrowSeries.scatter` would also sort.
                 sorting_indices = pc.sort_indices(df[token]._native_series)  # type: ignore[call-overload]
                 return [
-                    ser._from_native_series(pc.take(ser._native_series, sorting_indices))  # type: ignore[call-overload]
+                    ser._from_native_series(pc.take(ser._native_series, sorting_indices))
                     for ser in result
                 ]
         else:

narwhals/_arrow/series.py

@@ -674,7 +674,7 @@ def fill_aux(
 
         if value is not None:
             _, value = extract_native(self, value)
-            series = pc.fill_null(self.native, value)  # type: ignore[attr-defined]
+            series = pc.fill_null(self.native, value)
         elif limit is None:
             fill_func = (
                 pc.fill_null_forward if strategy == "forward" else pc.fill_null_backward
@@ -1100,19 +1100,11 @@ def _hist_from_bin_count(bin_count: int):  # type: ignore[no-untyped-def] # noqa
                 range_ = pc.subtract(upper, lower)
                 width = pc.divide(pc.cast(range_, pa_float), lit(float(bin_count)))
 
-            bin_proportions = pc.divide(
-                pc.subtract(cast("pc.NumericOrTemporalArray", self.native), lower),
-                width,
-            )
-            bin_indices: ArrowChunkedArray = cast(
-                "ArrowChunkedArray", pc.floor(bin_proportions)
-            )
-
-            # NOTE: stubs leave unannotated
-            if_else: Incomplete = pc.if_else
+            bin_proportions = pc.divide(pc.subtract(self.native, lower), width)
+            bin_indices = pc.floor(bin_proportions)
 
             # shift bins so they are right-closed
-            bin_indices = if_else(
+            bin_indices = pc.if_else(
                 pc.and_(
                     pc.equal(bin_indices, bin_proportions),
                     pc.greater(bin_indices, 0),

tests/series_only/is_ordered_categorical_test.py

@@ -54,5 +54,6 @@ def test_is_definitely_not_ordered_categorical(
 @pytest.mark.xfail(reason="https://github.com/apache/arrow/issues/41017")
 def test_is_ordered_categorical_pyarrow() -> None:
     tp = pa.dictionary(pa.int32(), pa.string(), ordered=True)
-    s = pa.chunked_array([pa.array(["a", "b"], type=tp)])  # type: ignore[list-item]
+    arr = pa.array(["a", "b"], type=tp)
+    s = pa.chunked_array([arr], type=tp)
     assert nw.is_ordered_categorical(nw.from_native(s, series_only=True))