Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block type change #7

Open
drzraf opened this issue Aug 25, 2022 · 1 comment
Open

block type change #7

drzraf opened this issue Aug 25, 2022 · 1 comment

Comments

@drzraf
Copy link
Contributor

drzraf commented Aug 25, 2022

In the WP build, at https://plugins.trac.wordpress.org/browser/timeline-block/trunk/includes/cool-timeline-block/dist/blocks.build.js
The block is named cp-timeline/content-timeline-block

This is also the case of the build provided in this repository at https://github.com/narinder9/story-timeline-block/blob/e41892fbee15612c29998480e11582d9bea9de23/includes/cool-timeline-block/dist/blocks.build.js

But in the source code :
https://github.com/narinder9/story-timeline-block/blob/e41892fbee15612c29998480e11582d9bea9de23/includes/cool-timeline-block/src/story-timeline/block.js#L66
The block is named cp-timeline/content-timeline (no -block suffix)

Compiling and using this break existing blocks.

Any explanation about the intent / issue?

@drzraf
Copy link
Contributor Author

drzraf commented Oct 22, 2022

Gentle ping.
I reverted this as part of #9

Revert block type renaming to the historical values in order to avoid breaking existing setup

... but your future-plans regarding this would be important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant