Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken block compatibility #23

Open
drzraf opened this issue Apr 4, 2023 · 0 comments
Open

broken block compatibility #23

drzraf opened this issue Apr 4, 2023 · 0 comments

Comments

@drzraf
Copy link
Contributor

drzraf commented Apr 4, 2023

In 8d203c9, in includes/cool-timeline-block/src/story-timeline-child/edit.js

-                             tagName="h3"
+                                 className="timeline-block_title"
+                             tagName={headingTag}
+                               <div className='timeline-block_desc'>

Before:

<div class="wp-block-cp-timeline-content-timeline-block-child swiper-slide"><div class="timeline-content icon-false ">
<div class=" timeline-block-timeline ctl-row  position-left"><div class="ctl-6 timeline-block-time"><div class="story-time"><p>SEPTEMBER</p>
</div></div><div class="timeline-block-icon">

</div>
<div class="ctl-6 timeline-block-detail"><div class="story-details"><div class="story-image"><img src="https://my/file.jpg" alt="" class="wp-image-6619"/></div><div class="story-content"><h3>
</h3>
<p>MYCONTENT</p></div></div></div></div></div></div>

After:

<div class="wp-block-cp-timeline-content-timeline-block-child swiper-slide"><div class="timeline-content icon-false ">
<div class="timeline-block-timeline ctl-row  position-left"><div class="ctl-6 timeline-block-time"><div class="story-time"><p>SEPTEMBER</p>
</div></div><div class="timeline-block-icon">

<svg stroke="currentColor" fill="currentColor" stroke-width="0" viewBox="0 0 512 512" height="1em" width="1em" xmlns="http://www.w3.org/2000/svg"><path d="M256 8C119 8 8 119 8 256s111 248 248 248 248-111 248-248S393 8 256 8z"></path></svg>
^^^^^^^^^^^^^^^^^^^^^^^ Compatibility not ensured
</div>
<div class="ctl-6 timeline-block-detail"><div class="story-details"><div class="story-image"><img src="https://my/file.jpg" alt="" class="wp-image-6619"/></div><div class="story-content">
<h3 class="timeline-block_title">
           ^^^^^^^^^^^^^^^^^^^ Compatibility not ensured
</h3>
<div class="timeline-block_desc">
            ^^^^^^^^^^^^^^^^^^^ Compatibility not ensured

<p>MYCONTENT</p></div></div></div></div></div></div></div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant