Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An incorrect message is displayed when the state has not been changed #15

Open
arthurgubaidullin opened this issue Aug 31, 2023 · 2 comments

Comments

@arthurgubaidullin
Copy link

Current Behavior

When the action is called and there is no state update, a message is displayed that the store has been changed. Which isn't true.

Снимок экрана 2023-08-31 в 19 24 53

Expected Behavior

I expect to see a proper message when the action is called and there is no state update.

GitHub Repo

https://github.com/arthurgubaidullin/ka-ledger/tree/95c002d755e6431a0c929ba1f719f701d5db51b9

Steps to Reproduce

  1. Clone the repository
  2. Run npm i && nx run web-app:serve:development
  3. Open browser
  4. Check logs

Nanostores and etc.

@nanostores/logger: 0.2.3
nanostores: 0.9.3

Failure Logs

No.

Package Manager Version

npm 9.5.1

Operating System

Linux

@euaaaio
Copy link
Member

euaaaio commented Aug 31, 2023

Very detailed and clean formatting. It is a pleasure to receive and explore such issues. Thanks.

... store was changed by action ... is the default message for each called action. Even if no change has happened inside the action. I think we can make this message more informative.

Am I understand correctly that everything works correctly and the problem is inaccurate log message of called actions?

@arthurgubaidullin
Copy link
Author

@euaaaio Yes, everything works fine. Just the message is confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants